fix(MAMEM-dataset): include all 11 subjects in BaseMAMEM initialization #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: - subjects=list(range(1, 12))
Collaborator
|
hey @Infernus-WIND, many thanks for the contibutions! |
bruAristimunha
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: BaseMAMEM subjects range excludes the 11th subject
What
This PR fixes the subjects initialization in
BaseMAMEM:subjects=list(range(1, 12))instead ofrange(1, 11)Why
The class is documented and intended to have 11 subjects (IDs 1..11).
Using
range(1, 11)(Python’s exclusive upper bound) unintentionallyexcludes subject 11, causing:
How
Single-line change in
BaseMAMEM.__init__: